Messages in this thread Patch in this message | | | Date | Sun, 19 Apr 2009 08:25:51 GMT | From | tip-bot for Cyrill Gorcunov <> | Subject | [tip:x86/apic] x86: smpboot - wakeup_secondary should be done via __cpuinit section |
| |
Commit-ID: cece3155d869a50ba534ed161b5a05e8a29dcad0 Gitweb: http://git.kernel.org/tip/cece3155d869a50ba534ed161b5a05e8a29dcad0 Author: Cyrill Gorcunov <gorcunov@gmail.com> AuthorDate: Sat, 18 Apr 2009 23:45:28 +0400 Committer: Ingo Molnar <mingo@elte.hu> CommitDate: Sun, 19 Apr 2009 10:22:14 +0200
x86: smpboot - wakeup_secondary should be done via __cpuinit section
A caller (do_boot_cpu) already has __cpuinit attribute.
Since HOTPLUG_CPU depends on SMP && HOTPLUG it doesn't lead to panic at moment.
[ Impact: cleanup ]
Signed-off-by: Cyrill Gorcunov <gorcunov@openvz.org> LKML-Reference: <20090418194528.GD25510@lenovo> Signed-off-by: Ingo Molnar <mingo@elte.hu>
--- arch/x86/kernel/smpboot.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/x86/kernel/smpboot.c b/arch/x86/kernel/smpboot.c index bf8ad63..d2e8de9 100644 --- a/arch/x86/kernel/smpboot.c +++ b/arch/x86/kernel/smpboot.c @@ -504,7 +504,7 @@ void __inquire_remote_apic(int apicid) * INIT, INIT, STARTUP sequence will reset the chip hard for us, and this * won't ... remember to clear down the APIC, etc later. */ -int __devinit +int __cpuinit wakeup_secondary_cpu_via_nmi(int logical_apicid, unsigned long start_eip) { unsigned long send_status, accept_status = 0; @@ -538,7 +538,7 @@ wakeup_secondary_cpu_via_nmi(int logical_apicid, unsigned long start_eip) return (send_status | accept_status); } -static int __devinit +static int __cpuinit wakeup_secondary_cpu_via_init(int phys_apicid, unsigned long start_eip) { unsigned long send_status, accept_status = 0;
| |