lkml.org 
[lkml]   [2009]   [Apr]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [microblaze-uclinux] [PATCH 11/11] microblaze: Kconfig: Enable drivers for Microblaze
On Thu, Apr 16, 2009 at 11:01 PM, John Williams
<john.williams@petalogix.com> wrote:
> On Thu, Apr 16, 2009 at 7:56 PM,  <monstr@monstr.eu> wrote:
>> From: Michal Simek <monstr@monstr.eu>
>>
>> Signed-off-by: Michal Simek <monstr@monstr.eu>
>
> ACK from a MicroBlaze perspective, but some other comments below:

Acked-by: Grant Likely <grant.likely@secretlab.ca>

But I'm not sure who should pick this up.

>
> A note more for the Xilinx PPC folks (ie Grant Likely):
>
> Shouldn't some of these Kconfig depends for PPC be unified?  We have:
>
>>  config XILINX_SYSACE
>>        tristate "Xilinx SystemACE support"
>> -       depends on 4xx
>> +       depends on 4xx || MICROBLAZE
>
>>  config XILINX_HWICAP
>>        tristate "Xilinx HWICAP Support"
>> -       depends on XILINX_VIRTEX
>> +       depends on XILINX_VIRTEX || MICROBLAZE
>
>
>>  config GPIO_XILINX
>>        bool "Xilinx GPIO support"
>> -       depends on PPC_OF
>> +       depends on PPC_OF || MICROBLAZE
>>        help
>>          Say yes here to support the Xilinx FPGA GPIO device
>
> Are these all really different options?  PPC_OF?  XILINX_VIRTEX?  4xx?

xsysace should just depend on either PPC or OF. It is applicable to
more than just virtex/spartan systems (I know of at least one
non-virtex 440 board with a systemace, hence the 4xx usage), and it is
conceivable that it would be used on other architectures.

XILINX_VIRTEX makes some sense for hwicap

PPC_OF doesn't have any real meaning anymore. PPC would be better.

g.

--
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2009-04-17 09:01    [W:0.045 / U:7.644 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site