Messages in this thread | | | Date | Fri, 17 Apr 2009 16:55:27 -0700 | From | "H. Peter Anvin" <> | Subject | Re: [PATCH] [14/28] x86: MCE: Add MSR read wrappers for easier error injection |
| |
Andi Kleen wrote: > > If someone feels strongly about that I can do that, but personally > I would think using standard function return arguments without > macros is more regular and more readable in general. That seems > to be also the general trend in the source base, going away from > magic macros. > > Do you feel strongly about it? >
I would agree with Andi on this; macros or not macros, we should use "function-like" style, analogous to rdmsrl() and wrmsrl() in this case.
Inline functions are also preferred over macros, obviously.
-hpa
| |