lkml.org 
[lkml]   [2009]   [Apr]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] tracing/lockdep: turn lock->name into an array
On Fri, Apr 17, 2009 at 01:36:58PM -0400, Steven Rostedt wrote:
>
>
> On Fri, 17 Apr 2009, Peter Zijlstra wrote:
>
> > On Fri, 2009-04-17 at 10:25 -0700, Jeremy Fitzhardinge wrote:
> > > Ingo Molnar wrote:
> > > > We could zap all pending trace entries on module unload (it is a
> > > > rare operation)
> > >
> > > ....Unless you're trying to trace something across a module unload. I
> > > don't know if its at all practical, but it would be nice to just zap the
> > > pointers within the buffer, rather than the whole buffer.
> >
> > I think the new __string() thing that's in the works will avoid the
> > whole problem by copying the string into the buffer, instead of keeping
> > a reference.
>
> Speaking of which. We have not heard back from Frederic on this yet. I
> hope he's taking a break, enjoying the sun, and not stuck on some tricky
> macro crap ;-)
>
> -- Steve
>



Oh you haven't yet received my mail about that?
It said I was cheering up about your and Peter's idea of using offsets
instead of pointer because of the end result:

- We can use as much __string() as we want
- No need for something else, such as the strcpy bits
- We are not forced to put it in the end of the patch
- Which means I will implement that in a v3 very soon ;-)

Frederic.



\
 
 \ /
  Last update: 2009-04-17 22:33    [W:0.062 / U:0.060 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site