Messages in this thread | | | Date | Fri, 17 Apr 2009 12:32:24 -0400 (EDT) | From | Steven Rostedt <> | Subject | Re: [PATCH 2/4] x86/pvops: target CREATE_TRACE_POINTS to particular subsystems |
| |
On Fri, 17 Apr 2009, Jeremy Fitzhardinge wrote:
> Steven Rostedt wrote: > > Instead of doing it this way, what about not having this new header, and > > just do: > > > > > > #ifdef CREATE_IRQ_TRACE_POINTS > > #define CREATE_TRACE_POINTS > > #endif > > #include <trace/define_trace.h> > > > > Heck, define_trace.h is only defined when CREATE_TRACE_POINTS is defined, > > why not just remove that and have: > > > > #ifdef CREATE_IRQ_TRACE_POINTS > > #define <trace/define_trace.h> > > #endif > > > > The whole trickery with the CREATE_TRACE_POINTS was to avoid the #if in the > > trace headers anyway. If we can't avoid it. We don't need to add more > > confusion to the mix. > > > > OK, and remove the test for CREATE_TRACE_POINTS in define_trace.h altogether? > Works for me. > Uh, still needs the #undef CREATE_IRQ_TRACE_POINTS.
Ah yes! It needs to be:
#ifdef CONFIG_IRQ_TRACE_POINTS #undef CONFIG_IRQ_TRACE_POINTS #include <trace/define_trace.h> #endif
Otherwise we get into the recursion again.
-- Steve
| |