Messages in this thread | | | Date | Fri, 17 Apr 2009 08:20:51 -0700 | From | Jeremy Fitzhardinge <> | Subject | Re: [PATCH 3/5] tracing/events: add rcu locking around trace event prints |
| |
Steven Rostedt wrote: > Ted, is this patch still needed? > > I'm starting to have second thoughts on this patch because it may require > adding: #include <linux/rcupdate.h> in include/trace/ftrace.h. Jeremy has > been struggling with include hell with these files. > > Hmm, maybe this is not an issue because we undef CREATE_TRACE_POINTS > before calling this. > > Jeremy, > > Do you see a problem if we include linux/rcupdate.h in ftrace.h? > Remember, CREATE_TRACE_POINTS is undefined here. > Hm, I don't think that matters; I'm seeing the #include problems when generating asm-offsets.h, which doesn't have CREATE_TRACE_POINTS set.
Or are you saying that you only need to include linux/rcupdate.h when CREATE_TRACE_POINTS is set?
J
| |