lkml.org 
[lkml]   [2009]   [Apr]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 5/5] x86: fix x2apic/intr-remap resume

* Weidong Han <weidong.han@intel.com> wrote:

> #ifdef CONFIG_INTR_REMAP
> - if (intr_remapping_enabled)
> - reenable_intr_remapping(EIM_32BIT_APIC_ID);
> + if (intr_remapping_enabled) {
> + if (x2apic)
> + reenable_intr_remapping(EIM_32BIT_APIC_ID);
> + else
> + reenable_intr_remapping(EIM_8BIT_APIC_ID);

ok, we had this sequence before. Might be worthwile to push the
x2apic condition into reenable_intr_remapping() itself? That would
simplify the call sites.

Ingo


\
 
 \ /
  Last update: 2009-04-17 16:19    [W:0.147 / U:0.028 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site