| Date | Fri, 17 Apr 2009 16:15:16 +0200 | From | Ingo Molnar <> | Subject | Re: [PATCH 5/5] x86: fix x2apic/intr-remap resume |
| |
* Weidong Han <weidong.han@intel.com> wrote:
> #ifdef CONFIG_INTR_REMAP > - if (intr_remapping_enabled) > - reenable_intr_remapping(EIM_32BIT_APIC_ID); > + if (intr_remapping_enabled) { > + if (x2apic) > + reenable_intr_remapping(EIM_32BIT_APIC_ID); > + else > + reenable_intr_remapping(EIM_8BIT_APIC_ID);
ok, we had this sequence before. Might be worthwile to push the x2apic condition into reenable_intr_remapping() itself? That would simplify the call sites.
Ingo
|