lkml.org 
[lkml]   [2009]   [Apr]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 8/8] irq: make ht irq_desc numa aware

* Yinghai Lu <yinghai@kernel.org> wrote:

> Impact: use create_irq_nr
>
> try to get irq_desc on the node with create_irq_nr
>
> Signed-off-by: Yinghai Lu <yinghai@kernel.org>
> ---
> drivers/pci/htirq.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> Index: linux-2.6/drivers/pci/htirq.c
> ===================================================================
> --- linux-2.6.orig/drivers/pci/htirq.c
> +++ linux-2.6/drivers/pci/htirq.c
> @@ -98,6 +98,7 @@ int __ht_create_irq(struct pci_dev *dev,
> int max_irq;
> int pos;
> int irq;
> + int node;
>
> pos = pci_find_ht_capability(dev, HT_CAPTYPE_IRQ);
> if (!pos)
> @@ -125,7 +126,8 @@ int __ht_create_irq(struct pci_dev *dev,
> cfg->msg.address_lo = 0xffffffff;
> cfg->msg.address_hi = 0xffffffff;
>
> - irq = create_irq();
> + node = dev_to_node(&dev->dev);
> + irq = create_irq_nr(0, node);
>
> if (irq <= 0) {
> kfree(cfg);

this too looks nice.

The whole series has become very reasonable (modulo the minor
structure and Cc: related comments i made).

It's obviously too late in .30 to push it upstream, so the best
action is to mark it broken upstream, then remove + rewrite it in
the IRQ tree and we'll have all this done properly in v2.6.31.

Thomas, Eric, Suresh, what do you think?

Ingo


\
 
 \ /
  Last update: 2009-04-16 11:25    [from the cache]
©2003-2011 Jasper Spaans