lkml.org 
[lkml]   [2009]   [Apr]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[tip:irq/urgent] x86/irq: mark NUMA_MIGRATIE_IRQ_DESC broken
    Commit-ID:  c822f79d3a5a7e53763e5a5c2dadc27cdd240504
    Gitweb: http://git.kernel.org/tip/c822f79d3a5a7e53763e5a5c2dadc27cdd240504
    Author: Yinghai Lu <yinghai@kernel.org>
    AuthorDate: Wed, 15 Apr 2009 18:39:13 -0700
    Committer: Ingo Molnar <mingo@elte.hu>
    CommitDate: Fri, 17 Apr 2009 02:56:52 +0200

    x86/irq: mark NUMA_MIGRATIE_IRQ_DESC broken

    It causes crash on system with lots of cards with MSI-X
    when irq_balancer enabled...

    The patches fixing it were both complex and fragile, according
    to Eric they were also doing quite dangerous things to the
    hardware.

    Instead we now have patches that solve this problem via static
    NUMA node mappings - not dynamic allocation and balancing.

    The patches are much simpler than this method but are still too
    large outside of the merge window, so we mark the dynamic balancer
    as broken for now, and queue up the new approach for v2.6.31.

    [ Impact: deactivate broken kernel feature ]

    Reported-by: Suresh Siddha <suresh.b.siddha@intel.com>
    Signed-off-by: Yinghai Lu <yinghai@kernel.org>
    Cc: Andrew Morton <akpm@linux-foundation.org>
    Cc: "Eric W. Biederman" <ebiederm@xmission.com>
    Cc: Rusty Russell <rusty@rustcorp.com.au>
    LKML-Reference: <49E68C41.4020801@kernel.org>
    Signed-off-by: Ingo Molnar <mingo@elte.hu>


    ---
    arch/x86/Kconfig | 1 +
    1 files changed, 1 insertions(+), 0 deletions(-)

    diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
    index bc25b9f..b1d2be7 100644
    --- a/arch/x86/Kconfig
    +++ b/arch/x86/Kconfig
    @@ -277,6 +277,7 @@ config SPARSE_IRQ
    config NUMA_MIGRATE_IRQ_DESC
    bool "Move irq desc when changing irq smp_affinity"
    depends on SPARSE_IRQ && NUMA
    + depends on BROKEN
    default n
    ---help---
    This enables moving irq_desc to cpu/node that irq will use handled.

    \
     
     \ /
      Last update: 2009-04-17 03:05    [W:0.025 / U:2.132 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site