Messages in this thread | | | From | "Zhaolei" <> | Subject | Re: [PATCH 2/2] ftrace: Code cleanup for kernel/trace/trace_events_stage_*.h | Date | Fri, 17 Apr 2009 08:31:50 +0800 |
| |
* From: "Steven Rostedt" <rostedt@goodmis.org> > > On Mon, 6 Apr 2009, Steven Rostedt wrote: > >> >> On Fri, 3 Apr 2009, Zhaolei wrote: >> >> > Add TRACE_FORMAT's define for trace_events_stage_2.h. >> > Although it is already defined in trace_events_stage_1.h, we should make each >> > function independence. >> > >> > Move TP_fast_assign's define from trace_events_stage_2.h to >> > trace_events_stage_3.h because it is used there. >> > >> > Unify TRACE_EVENT's 5th argument's name to "assign" >> > >> > Impact: cleanup, no functionality changed >> > >> > Signed-off-by: Zhao Lei <zhaolei@cn.fujitsu.com> >> >> I see what you are doing here, but I'm a little hesitant to apply it. >> I'm getting ready to travel, so I do not have the time to look deeper at >> this today. I'll try to do it while I'm traveling. > > Hi Zhao, > > As you probably noticed, the staging code has been combined into > include/trace/ftrace.h > > Is this patch (or a variant) still needed? Hello, Steven
I see your patchset, it is nice. This patch is no use now, please ignore it.
Thanks Zhaolei > > -- Steve > > > | |