Messages in this thread | | | Date | Thu, 16 Apr 2009 16:28:52 -0700 | From | "H. Peter Anvin" <> | Subject | Re: microcode driver newly spews warnings |
| |
Jeff Garzik wrote: >> Jeff, did this do the trick for you? > > Yes -- but I worry about keeping sysfs files around too long? > > Jeff
OK, what isn't clear to me is what the proper return value is in this case. In particular, how with the caller react to mc_sysdev_add() returning a nonzero value, but still have the sysdev devices created and retained?
What I would expect happen would be that sysdev_register_driver() would return an error and we would unregister the notifier, which really isn't the right thing -- if the intent is to keep the sysdev devices around for a possible later update then we should presumably return zero there, i.e. ignore the return value from microcode_init_cpu(); completely?
-hpa
| |