lkml.org 
[lkml]   [2009]   [Apr]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] x86/pci: make pci_mem_start to be aligned only -v3

* Linus Torvalds <torvalds@linux-foundation.org> wrote:

> On Thu, 16 Apr 2009, Jesse Barnes wrote:
> >
> > Any comments on this one, Linus? Should I include your ack?
>
> I'm not ready to ack it, no. I don't think the suggested patch is very
> clean or necessarily sensible as-is. It seems very ad-hoc.
>
> I was literally thinking of something like
> "round up from the last RAM by X"
> "round up from the last reserved region by Y"
> "pick the bigger of the two"
>
> with helper functions for the two cases and comments along the
> lines of why we do it. Something that was a bit more obvious about
> what it's doing and why.

That's sensible - but i'd also like to inject hpa's add-on idea: if
we do that then we should do it _explicitly_ and _visibly_, by
injecting an artificial e820 reservation range to all expected
"vulnerable" holes we cannot fully trust.

We'd do that after all the fixed resources are allocated, but before
dynamic PCI allocations.

That prevents the PCI layer from dynamically allocating anything
into that protective zone, and documents it as well (and makes it
visible in boot logs, etc.) - instead of just a silent rule
somewhere that no-one will really see if it breaks.

Or would this be a bad idea for some obvious reason i missed?

Ingo


\
 
 \ /
  Last update: 2009-04-16 19:01    [W:0.102 / U:1.980 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site