Messages in this thread | | | From | "Pallipadi, Venkatesh" <> | Date | Wed, 15 Apr 2009 11:12:50 -0700 | Subject | RE: 2.6.29 git master and PAT problems |
| |
>-----Original Message----- >From: Arkadiusz Miskiewicz [mailto:a.miskiewicz@gmail.com] >Sent: Wednesday, April 15, 2009 10:46 AM >To: Pallipadi, Venkatesh >Cc: Ingo Molnar; Thomas Gleixner; H. Peter Anvin; Siddha, >Suresh B; linux-kernel@vger.kernel.org; Jesse Barnes >Subject: Re: 2.6.29 git master and PAT problems > >On Thursday 09 of April 2009, Pallipadi, Venkatesh wrote: >> On Wed, Apr 08, 2009 at 01:17:11AM -0700, Ingo Molnar wrote: >> > * Arkadiusz Miskiewicz <a.miskiewicz@gmail.com> wrote: >> > > On Wednesday 08 of April 2009, Pallipadi, Venkatesh wrote: >> > > > On Tue, Apr 07, 2009 at 02:12:28AM -0700, Arkadiusz >Miskiewicz wrote: >> > > > > On Tuesday 07 of April 2009, Pallipadi, Venkatesh wrote: >> > > > > > On Thu, 2009-04-02 at 00:12 -0700, Arkadiusz >Miskiewicz wrote: >> > > > > > >> > > > > > I was finally able to reproduce the problem of >"freeing invalid >> > > > > > memtype" with upstream git kernel (commit >0221c81b1b) + latest >> > > > > > xf86 intel driver. But, with upstream + the patch >I had sent you >> > > > > > earlier in this thread >> > > > > > >(http://marc.info/?l=linux-kernel&m=123863345520617&w=2) I don't >> > > > > > see those freeing invalid memtype errors anymore. >> > > > > > >> > > > > > Can you please double check with current git and >that patch and >> > > > > > let me know if you are still seeing the problem. >> > > > > >> > > > > Latest linus tree + that patch (it's really applied >here), xserver >> > > > > 1.6, libdrm from git master, intel driver from git master, >> > > > > previously mesa 7.4 (and 7.5 snap currently), >tremolous.net 1.1.0 >> > > > > game (tremolous-smp binary), GM45 gpu. >> > > > > >> > > > > To reproduce I just need to run tremolous-smp and >connect to some >> > > > > map. When map finishes loading I instantly get: >> > > >> > > [...] >> > > >> > > > OK. One more test patch below, applies over linus's >git and you can >> > > > ignore the earlier patch. The patch below should get rid of the >> > > > problem and as it removes the track/untrack of vm_insert_pfn >> > > > completely. This will also eliminate the overhead of >hundreds or >> > > > thousands of entries in pat_memtype_list. Can you >please test it. >> > > >> > > With this patch I'm no longer able to reproduce problem. Thanks! >> > >> > Great, thanks! >> > >> > Venki, mind sending a patch with a proper changelog, Reported-by, >> > Tested-by tags, with Nick and Andrew Cc:-ed for the memory.c bits, >> > etc.? >> >> Ingo, >> >> Below is the cleaner version of the patch. It does not have >any changes in >> mm as we are only removing the tracking inside the PAT code. >I have left >> the generic mm interface as is, until we fully resolve the >issue in future. >> >> Thanks, >> Venki >> >> Subject: [PATCH] x86, PAT: Remove page granularity tracking for >> vm_insert_pfn maps > >I wonder what's with these patches that they missed rc2 ? > >This one and Subject: [PATCH] x86, PAT: Remove duplicate >memtype reserve in >pci mmap >
I do see the above patch in rc2. Here http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=5a3ae276057840f0e60664c12fc3ef80aa59d1d4
But, the patch below has not yet made it. http://marc.info/?l=linux-kernel&m=123923026401648&w=2
Ingo: Can you push this along?
Thanks, Venki
| |