lkml.org 
[lkml]   [2009]   [Apr]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: meminfo Committed_AS underflows
* KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> [2009-04-15 11:04:59]:

> committed = atomic_long_read(&vm_committed_space);
> + if (committed < 0)
> + committed = 0;

Isn't this like pushing the problem under the rug?

> allowed = ((totalram_pages - hugetlb_total_pages())
> * sysctl_overcommit_ratio / 100) + total_swap_pages;
>
> Index: b/mm/swap.c
> ===================================================================
> --- a/mm/swap.c
> +++ b/mm/swap.c
> @@ -519,7 +519,7 @@ EXPORT_SYMBOL(pagevec_lookup_tag);
> * We tolerate a little inaccuracy to avoid ping-ponging the counter between
> * CPUs
> */
> -#define ACCT_THRESHOLD max(16, NR_CPUS * 2)
> +#define ACCT_THRESHOLD max_t(long, 16, num_online_cpus() * 2)
>

Hmm.. this is a one time expansion, free of CPU hotplug.

Should we use nr_cpu_ids or num_possible_cpus()?


--
Balbir


\
 
 \ /
  Last update: 2009-04-15 05:39    [W:0.083 / U:1.144 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site