Messages in this thread Patch in this message | | | From | Rusty Russell <> | Subject | Re: [PATCH 2/4] irq: make set_affinity to return status | Date | Wed, 15 Apr 2009 12:57:44 +0930 |
| |
On Wed, 15 Apr 2009 06:12:52 am Yinghai Lu wrote: > > Impact: prepare to use it to keep affinity consistent > > according to Ingo, change set_affinity() in irq_chip to return int.
I prefer a bool, or an actual -errno rather than -1. Maybe Ingo feels differently?
Plus:
> @@ -199,6 +199,8 @@ static void octeon_irq_ciu0_set_affinity > */ > cvmx_read_csr(CVMX_CIU_INTX_EN0(cvmx_get_core_num() * 2)); > write_unlock(&octeon_irq_ciu0_rwlock); > + > + reutrn 0; > }
Typo.
Thanks, Rusty.
| |