lkml.org 
[lkml]   [2009]   [Apr]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] tracing/filters: allow on-the-fly filter switching
On Wed, Apr 15, 2009 at 09:12:58AM +0800, Li Zefan wrote:
> > Ok, the whole design and concept looks nice.
> >
> > But you really need to think about a locking scheme to protect
> > the filters from user files.
> >
>
> I noticed this and fixed it in that
> "[PATCH 7/7] tracing/filters: make filter preds RCU safe"
>
> I'll try to fix it on top of Tom's on-the-fly filter swithcing,
> if Tom hasn't started to do this.


Ah, ok.

Thanks.


> > Also, is filter_add_pred() supposed to be available for in-kernel
> > uses by other tracers or something?
> > If this is planned, the locking could be even deeper than my comments.
> >
> > Other than these comments:
> >
> > Acked-by: Frederic Weisbecker <fweisbec@gmail.com>
> >
> > Thanks!



\
 
 \ /
  Last update: 2009-04-15 03:59    [W:0.067 / U:16.448 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site