lkml.org 
[lkml]   [2009]   [Apr]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] FRV: Fix the section attribute on UP DECLARE_PER_CPU()


On Tue, 14 Apr 2009, David Howells wrote:
>
> To fix this, DECLARE_PER_CPU() should simply interpose the same section
> attribute as does DEFINE_PER_CPU(). However, this is made slightly more
> complex by virtue of the fact that there are several variants on DEFINE, so
> these need to be matched by variants of DECLARE.

This needs to be fixed.

We should have the DECLARE_PER_CPU() #defines next to the DEFINE_PER_CPU
ones, rather than somewhere else.

So moving the logic to <asm-generic/percpu.h> is wrong - make it all be in
<linux/percpu.h> so that they can be maintained together.

Linus


\
 
 \ /
  Last update: 2009-04-14 19:05    [W:0.055 / U:0.732 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site