lkml.org 
[lkml]   [2009]   [Apr]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH -tip] x86: cpu_debug.c prepare report if files are inappropriate or CPU is not supported

* Jaswinder Singh Rajput <jaswinder@kernel.org> wrote:

> + if (!per_cpu(cpu_modelflag, cpu))

hm, on a second look - the whole cpu_model / cpu_modelflag
business in arch/x86/kernel/cpu/cpu_debug.c looks
over-complicated and broken. You encode it into a
'modelflag':

per_cpu(cpu_model, cpu) = ((cpui->x86_vendor << 16) |
(cpui->x86 << 8) |
(cpui->x86_model));

just to decode it later on:

flag = per_cpu(cpu_model, cpu);

switch (flag >> 16) {

That does not make much sense. Please use a proper
boot_cpu_data.x86_vendor switch() statement, ok?

Ingo


\
 
 \ /
  Last update: 2009-04-14 18:55    [W:0.046 / U:0.276 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site