lkml.org 
[lkml]   [2009]   [Apr]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH -tip] x86: cpu/intel_cacheinfo.c fix compilation warnings
From
Date
On Tue, 2009-04-14 at 15:32 +0200, Ingo Molnar wrote:
> * Jaswinder Singh Rajput <jaswinder@kernel.org> wrote:
>
> > fix:
> > arch/x86/kernel/cpu/intel_cacheinfo.c: In function ‘show_cache_disable’:
> > arch/x86/kernel/cpu/intel_cacheinfo.c:712: warning: unused variable ‘node’
> > arch/x86/kernel/cpu/intel_cacheinfo.c: In function ‘store_cache_disable’:
> > arch/x86/kernel/cpu/intel_cacheinfo.c:739: warning: unused variable ‘node’
>
> you again 'fixed' a warning.
>
> this made you fail to analyze and miss the real reason for this for
> example:
>
> > arch/x86/kernel/cpu/intel_cacheinfo.c:739: warning: unused variable ‘node’
>
> > - int node = cpu_to_node(cpu);
>
> the local variable is clearly initialized.
>
> The problem is not with that variable - the problem is most likely
> with the cpu_to_node() macro not creating a reference to the 'cpu'
> variable in a compiler-visible way, in the !NUMA case.
>
> The typical way to solve this is to add a dummy:
>
> (void)(cpu)
>
> use to the 'cpu' parameter to the macro definition - or, (which is a
> much better solution), to convert it to an inline function.
>

OK send patch:
[PATCH -tip] x86: k8.h reference to node in node_to_k8_nb_misc for !CONFIG_K8_NB

Thanks,

--
JSR

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2009-04-14 18:51    [W:0.028 / U:36.844 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site