lkml.org 
[lkml]   [2009]   [Apr]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH -tip] x86: cpu_debug.c prepare report if files are less or more then expected

* Jaswinder Singh Rajput <jaswinder@kernel.org> wrote:

> This will prepare the report to update cpu_debug
>
> Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@gmail.com>
> ---
> arch/x86/include/asm/cpu_debug.h | 1 +
> arch/x86/kernel/cpu/cpu_debug.c | 12 ++++++++++++
> 2 files changed, 13 insertions(+), 0 deletions(-)
>
> diff --git a/arch/x86/include/asm/cpu_debug.h b/arch/x86/include/asm/cpu_debug.h
> index 2228020..b64da5d 100644
> --- a/arch/x86/include/asm/cpu_debug.h
> +++ b/arch/x86/include/asm/cpu_debug.h
> @@ -187,6 +187,7 @@ enum cpu_processor_bit {
> #define CPU_ALL (CPU_INTEL_ALL | CPU_AMD_ALL)
>
> #define MAX_CPU_FILES 512
> +#define MIN_CPU_FILES 10
>
> struct cpu_private {
> unsigned cpu;
> diff --git a/arch/x86/kernel/cpu/cpu_debug.c b/arch/x86/kernel/cpu/cpu_debug.c
> index 46e29ab..1c3ebd4 100644
> --- a/arch/x86/kernel/cpu/cpu_debug.c
> +++ b/arch/x86/kernel/cpu/cpu_debug.c
> @@ -838,6 +838,14 @@ static int cpu_init_allreg(unsigned cpu, struct dentry *dentry)
> return err;
> }
>
> +/* Send Report to maintainer if files are less or more then expected */
> +static void send_report(int files, struct cpuinfo_x86 *cpui)
> +{
> + pr_info("Please report \"cpu_debug files %d for %x:%x:%x:%x\" to"
> + " jaswinderrajput@gmail.com\n", files, cpui->x86_vendor,
> + cpui->x86, cpui->x86_model, cpui->x86_mask);

i'd rather see this reported to linux-kernel@vger.kernel.org, plus
please use a WARN_ONCE() instead of a pr_info(). Hitting this is a
bug we want to fix.

Ingo


\
 
 \ /
  Last update: 2009-04-14 15:49    [W:0.083 / U:1.000 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site