[lkml]   [2009]   [Apr]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH] unbreak alpha percpu
    Hello, Martin.

    Martin Schwidefsky wrote:
    > I would like to get rid of that SHIFT_PERCPU_PTR mess. The patch from
    > Ivan will allow this, it uses a dummy variable to void the effect of a
    > static modifier for percpu variables in modules. The percpu variable
    > itself will be defined non-static, my gut feeling is that this is a
    > dirty little trick that might bite us in the future.
    > Another solution which I personally would prefer is to ban the use of
    > static percpu variables. Then the compiler will use the GOT to get the
    > address of percpu variables without any dirty tricks.

    Hmmm... even if we can make combination of DECLARE_PER_CPU() and
    static DEFINE_PER_CPU() trigger compile error? That pretty much
    implements most of what the programmer intends by "static" but yeah
    it's a bit convoluted.



     \ /
      Last update: 2009-04-14 11:07    [W:0.024 / U:10.128 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site