Messages in this thread | | | Date | Tue, 14 Apr 2009 01:01:10 +0200 | From | Ingo Molnar <> | Subject | Re: [PATCH] tracing/lockdep: turn lock->name into an array |
| |
* Frederic Weisbecker <fweisbec@gmail.com> wrote:
> TP_STRUCT__entry( > - __field(const char *, name) > + __array(char, name, LOCK_NAME_SIZE) > __field(unsigned long, wait_usec) > __field(unsigned long, wait_nsec_rem) > ),
Hm. These constants tend to grow - 25 will certainly be too narrow. But increasing it increases the record size as well.
I think we'll need an embedded __string() type, with a length field (but still also zero-delimited, for convenience), hm?
Ingo
| |