lkml.org 
[lkml]   [2009]   [Apr]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] tracing: mark get_parent_ip() notrace
From
Date

On Mon, 2009-04-13 at 14:17 +0800, Lai Jiangshan wrote:
> Frederic Weisbecker wrote:
> > On Thu, Apr 02, 2009 at 02:18:25PM +0800, Lai Jiangshan wrote:
> >> Impact: remove redundancy tracing log
> >>
> >> When tracer is "function" or "function_graph", too much
> >> "get_parent_ip" are recorded in ring_buffer.
> >
> >
> > Thanks, indeed this get_parent_ip was a bit harrassing
> > in the traces, though I still don't understand why it is
> > called so often.
> >
> > Anyway, tracing it seems to me not useful.
> >
> > Acked-by: Frederic Weisbecker <fweisbec@gmail.com>
> >
> >
>
> Hi, Ingo,
> Could you apply this fix?
>
> get_parent_ip() is a helper function for ftace, and it is called
> by preempt_disable() and preempt_enable(), so it is occurred very
> often.

I can pull it in too, if Ingo is busy.

-- Steve




\
 
 \ /
  Last update: 2009-04-13 16:47    [W:0.223 / U:0.052 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site