Messages in this thread | | | Date | Sun, 12 Apr 2009 21:53:04 +0400 | From | Cyrill Gorcunov <> | Subject | Re: [rfc 1/4] x86: irq.c - tiny cleanup |
| |
[Ingo Molnar - Sun, Apr 12, 2009 at 07:25:36PM +0200] | | * Cyrill Gorcunov <gorcunov@openvz.org> wrote: | | > Impact: cleanup | > | > 1) guard ack_bad_irq with printk_ratelimit since there is no | > guarantee we will not be flooded one day | > 2) use pr_emerg helper | > ... | Btw, this is not so theoretical - in the past i've had bugs where a | flood of these messages made the system unusable. (granted, it would | have been unusable even with rate-limiting - but it's still nice to | have a throttle in place for something like this.) | | Ingo |
I bet the only benefit is that a user will have some time to pull out camera and snap screen before it's scrolled with bad irq messages :)
Cyrill
| |