lkml.org 
[lkml]   [2009]   [Apr]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [GIT PULL] MN10300: Move arch headers to arch dir
On Sat, Apr 11, 2009 at 07:43:00AM +0100, Al Viro wrote:
> On Sat, Apr 11, 2009 at 07:45:16AM +0200, Sam Ravnborg wrote:
> > On Sat, Apr 11, 2009 at 11:42:01AM +0800, Jike Song wrote:
> > > On Sat, Apr 11, 2009 at 3:25 AM, Sam Ravnborg <sam@ravnborg.org> wrote:
> > > >
> > > > .gitignore is left in include/asm-mn10300.
> > > >
> > > > As the content of that file is obsoleted by your last patch it can safely be deleted.
> > > > Linus - can I ask you to do so?
> > > >
> > > > Sam
> > >
> > > off topic: there is also a .gitignore left in include/asm-arm.
> > But its there for a reason.
> > Arm generates mach-types.h and it should be ignored.
> >
> > include/asm-arm is no longer a sensible place for these files,
> > but for now I have no better place for them so they will
> > stay there for a while.
>
> How about a single directory for *all* generated headers? Only linux/version.h
> has many places including it and even that can be dealt with for a moment with
> linux/version.h consisting of #include <gen/version.h>. The rest doesn't
> need anything like that even for transition period - too few includes to care.

So you suggest: include/gen/

asm-offsets.h, mach-types.h and version.h is the ones with the highest count.

And version.h is an exported header which we cannot move in our exported
set of headers. Fortunately I have just checked in a patch so we can specify
an alternative destination when exporting so this should deal with version.h.

asm-offsets.h and mach-types.h require a small helper file as you suggest,
otherwise it would be a _huge_ patch.

We can later migrate more generated files to this location.
(autoconf.h, config/* etc).

Sam



\
 
 \ /
  Last update: 2009-04-11 09:57    [W:0.054 / U:0.716 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site