Messages in this thread | | | Date | Sat, 11 Apr 2009 14:15:50 -0700 | From | "H. Peter Anvin" <> | Subject | Re: [PATCH] deal with interrupt shadow state for emulated instruction |
| |
Avi Kivity wrote: >> >> - rip = kvm_rip_read(vcpu); >> - rip += vmcs_read32(VM_EXIT_INSTRUCTION_LEN); >> - kvm_rip_write(vcpu, rip); >> + if (!(interruptibility & interruptibility_mask)) >> + vmcs_write32(GUEST_INTERRUPTIBILITY_INFO, >> + interruptibility | interruptibility_mask); >> + vcpu->arch.interrupt_window_open = 0; >> > > Setting both _MOV_SS and _STI is wierd; can't happen on real hardware. >
Not at architecturally visible boundaries, for sure. It can be an implementation artifact internally to an instruction, though.
-hpa
-- H. Peter Anvin, Intel Open Source Technology Center I work for Intel. I don't speak on their behalf.
| |