lkml.org 
[lkml]   [2009]   [Apr]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [REGRESSION] commit 66c1ca0: {fbmem: fix fb_info->lock and mm->mmap_sem ...} causes Xfbdev not working
    On Sat, 11 Apr 2009 17:04:00 +0200 Andrea Righi <righi.andrea@gmail.com> wrote:

    > fbdev: fix info->lock deadlock in fbcon_event_notify()
    >
    > fb_notifier_call_chain() is called with info->lock held, i.e. in
    > do_fb_ioctl() => FBIOPUT_VSCREENINFO => fb_set_var() and the some
    > notifier callbacks, like fbcon_event_notify(), try to re-acquire
    > info->lock again.
    >
    > Remove the lock/unlock_fb_info() in all the framebuffer notifier
    > callbacks' and be sure to always call fb_notifier_call_chain() with
    > info->lock held.

    Thanks. So do you think we should proceed with this patch instead of
    reverting 66c1ca0?


    \
     
     \ /
      Last update: 2009-04-11 20:35    [W:2.903 / U:0.172 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site