Messages in this thread | | | Date | Sat, 11 Apr 2009 00:10:30 +0200 | From | Pierre Ossman <> | Subject | Re: [PATCH] mmc_spi: do propper retry managment in the block layer |
| |
On Wed, 8 Apr 2009 10:55:53 +0100 Wolfgang Mües <wolfgang.mues@auerswald.de> wrote:
> From: Wolfgang Muees <wolfgang.mues@auerswald.de> > > o This patch adds a propper retry managment for reading > and writing data blocks for mmc and mmc_spi. Blocks are > retransmitted 2 times in case of a transmission failure. > This patch was tested with induced transmission errors > by ESD pulses (and survived). > > Signed-off-by: Wolfgang Muees <wolfgang.mues@auerswald.de> >
NAK. Writes cannot be retried safely as upper layers rely on the fact that writes fail in a linear manner (a stupid assumption IMO, but that's the way things are).
> + /* Invalid response. This is most likely a transmission > + * error from card to host. > + */ > + case -EINVAL:
EINVAL is actually "host controller driver/hardware does not support this type of request".
Rgds -- -- Pierre Ossman
WARNING: This correspondence is being monitored by the Swedish government. Make sure your server uses encryption for SMTP traffic and consider using PGP for end-to-end encryption. [unhandled content-type:application/pgp-signature] | |