lkml.org 
[lkml]   [2009]   [Apr]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 2/2] ftrace: Output REC->var instead of __entry->varfor trace format

    * Zhaolei <zhaolei@cn.fujitsu.com> wrote:

    > * From: "Ingo Molnar" <mingo@elte.hu>
    > >
    > > * Zhaolei <zhaolei@cn.fujitsu.com> wrote:
    > >
    > >> print fmt: "irq=%d return=%s", __entry->irq, __entry->ret ? \"handled\" : \"unhandled\"
    > >>
    > >> "__entry" should be convert to "REC" by __stringify() macro.
    > >>
    > >> Signed-off-by: Zhao Lei <zhaolei@cn.fujitsu.com>
    > >> ---
    > >> kernel/trace/trace_events_stage_2.h | 4 ++--
    > >> 1 files changed, 2 insertions(+), 2 deletions(-)
    > >
    > > good fix, but it is causing build trouble when applied to latest
    > > tip/master:
    > >
    > > include/trace/sched_event_types.h:257:1: error: macro "__stringify"
    > > passed 3 arguments, but takes just 1
    > Hello, Ingo
    >
    > I tested this patch before send, but haven't see this error. env
    > is: gcc version 4.1.2 20070626 (Red Hat 4.1.2-14)
    >
    > This patch need on top of my previous one: [PATCH 1/2] Make
    > __stringify support variable argument macro Maybe this is the
    > reason.

    ah, indeed - i missed the 1/2 patch. I'll have another look.

    Ingo


    \
     
     \ /
      Last update: 2009-04-10 15:49    [W:0.024 / U:61.552 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site