Messages in this thread | | | Date | Fri, 10 Apr 2009 13:00:59 +0200 | From | Éric Piel <> | Subject | Re: [PATCH] Additional keys for dell-wmi |
| |
Matthew Garrett schreef: > On Wed, Apr 08, 2009 at 05:16:04PM -0400, Rafi Rubin wrote: > >> static struct key_entry dell_wmi_keymap[] = { >> {KE_KEY, 0xe045, KEY_PROG1}, >> + {KE_KEY, 0xe046, KEY_PROG2}, >> + {KE_KEY, 0xe047, KEY_PROG3}, > > Would this make more sense as a switch? That way userspace can know what > state the screen is in. > Indeed, that seems more logical. And in addition, there is a switch called SW_TABLET_MODE, which would fit perfectly. I guess at initialisation you can consider it is in standard mode, and actually sort out the real state on the first event received.
Eric begin:vcard fn;quoted-printable:=C3=89ric Piel n;quoted-printable:Piel;=C3=89ric org:Technical University of Delft;Software Engineering Research Group adr:HB 08.080;;Mekelweg 4;Delft;;2628 CD;The Netherlands email;internet:E.A.B.Piel@tudelft.nl tel;work:+31 15 278 6338 tel;cell:+31 6 2437 9135 x-mozilla-html:FALSE url:http://pieleric.free.fr version:2.1 end:vcard
| |