Messages in this thread | | | From | Philipp Reisner <> | Subject | Re: [PATCH 13/13] DRBD: final | Date | Wed, 1 Apr 2009 12:13:01 +0200 |
| |
On Monday 30 March 2009 21:05:30 Sam Ravnborg wrote: > > +# > > +config BLK_DEV_DRBD > > + tristate "DRBD Distributed Replicated Block Device support" > > + select INET > > + select PROC_FS > > + select CONNECTOR > > + select CRYPTO > > + select CRYPTO_HMAC > > Have you double checked that these symbols are supposed to be 'selected'? > If they: > - have dependencies > - have a prompt > then they most likely are not. >
Right! Reading kconfig-language.txt makes one wiser ;) I have changed them into dependencies.
> > @@ -0,0 +1,7 @@ > > +#CFLAGS_drbd_sizeof_sanity_check.o = -Wpadded # -Werror > > Commented out? >
Removed.
> > + > > +drbd-objs := drbd_buildtag.o drbd_bitmap.o drbd_proc.o \ > > + drbd_worker.o drbd_receiver.o drbd_req.o drbd_actlog.o \ > > + lru_cache.o drbd_main.o drbd_strings.o drbd_nl.o > > Please use: > drdb-y := drbd_buildtag.o drbd_bitmap.o drbd_proc.o > ... > > And my personal taste favours: > drdb-y := ... > drdb-y += ... >
Ok and ok, following your taste.
Thanks for those helpful hints!
-Phil -- : Dipl-Ing Philipp Reisner : LINBIT | Your Way to High Availability : Tel: +43-1-8178292-50, Fax: +43-1-8178292-82 : http://www.linbit.com
DRBD(R) and LINBIT(R) are registered trademarks of LINBIT, Austria.
| |