lkml.org 
[lkml]   [2009]   [Apr]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 4/4] add ksm kernel shared memory driver.
* Anthony Liguori (anthony@codemonkey.ws) wrote:
> The ioctl() interface is quite bad for what you're doing. You're
> telling the kernel extra information about a VA range in userspace.
> That's what madvise is for. You're tweaking simple read/write values of
> kernel infrastructure. That's what sysfs is for.

I agree re: sysfs (brought it up myself before). As far as madvise vs.
ioctl, the one thing that comes from the ioctl is fops->release to
automagically unregister memory on exit. This needs to be handled
anyway if some -p pid is added to add a process after it's running,
so less weight there.

thanks,
-chris


\
 
 \ /
  Last update: 2009-04-02 03:25    [W:0.131 / U:0.100 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site