Messages in this thread | | | Date | Wed, 1 Apr 2009 21:03:40 +0200 | From | Sam Ravnborg <> | Subject | Re: make headers_install broken for ARCH=m68k in 2.6.29-rc7. |
| |
On Wed, Apr 01, 2009 at 12:57:41PM -0400, Lennart Sorensen wrote: > On Thu, Mar 12, 2009 at 04:37:03AM -0500, Rob Landley wrote: > > So I'm doing this: > > > > make ARCH=m68k headers_install INSTALL_HDR_PATH=walrus > > > > And it doesn't install unistd_mm.h which is included from asm/unistd.h. (The > > file is there in arch/m68k/include/asm/unistd_mm.h, it just doesn't get > > installed. So any code that #includes <asm/unistd.h> results in a file not > > found error for the other one, which is essentially just a wrapper.) > > > > I don't understand what the code's currently doing here well enough to fix it, > > specifically where does this file list come from? The file > > arch/m68k/include/asm/Kbuild is adding "cachectl.h" to header-y, but there are > > 31 files getting installed from that directory and only one in there. If the > > list was just the contents of the directory, then unistd_mm.h (and > > unistd_no.h) would get installed, but they don't. I could add those two to > > the Kbuild file after cachectl.h, but is that the _right_ fix? Where are the > > other 31 identified? (Is it getting a listing of some _other_ directory?) > > I sent a patch to fix that on Feb 5th. I guess it hasn't been put in. > > It looked like this: > > Signed-of-by: Len Sorensen <lsorense@csclub.uwaterloo.ca> > > diff --git a/arch/m68k/include/asm/Kbuild b/arch/m68k/include/asm/Kbuild > index 1a922fa..d477927 100644 > --- a/arch/m68k/include/asm/Kbuild > +++ b/arch/m68k/include/asm/Kbuild > @@ -1,2 +1,18 @@ > include include/asm-generic/Kbuild.asm > header-y += cachectl.h > +header-y += param_mm.h > +header-y += param_no.h > +header-y += ptrace_mm.h > +header-y += ptrace_no.h > +header-y += setup_mm.h > +header-y += setup_no.h > +header-y += sigcontext_mm.h > +header-y += sigcontext_no.h > +header-y += siginfo_mm.h > +header-y += siginfo_no.h > +header-y += signal_mm.h > +header-y += signal_no.h > +header-y += swab_mm.h > +header-y += swab_no.h > +header-y += unistd_mm.h > +header-y += unistd_no.h
They decided to fix it by eliminating the *_{no,mm}.h files for exported headers. The patch is already in mainline.
Sam
| |