Messages in this thread | | | Date | Wed, 1 Apr 2009 17:53:45 +0100 | From | Matthew Garrett <> | Subject | Re: [PATCH 2/2] toshiba-acpi: Support TOS1900-type devices |
| |
On Thu, Apr 02, 2009 at 09:50:59AM +1700, Azael Avalos wrote: > On Wed, Apr 1, 2009 at 4:02 PM, Matthew Garrett <mjg59@srcf.ucam.org> wrote: > > Ok, can you try this and let me know what codes it generates (if it > > generates any)? It should go on top of the previous patches. > > Nothing gets generated, even if I change the method to ".INFO" and hotkey > events enabled with hci_write2(HCI_HOTKEY_EVENT, 1, 1, &hci_result) and > TECF set to 1 (see my DSDT). > > I was playing with the code yesterday trying to get some events reported, but no > luck so far. > > It appears that TOHK variable is _volatile_ and it just stores hotkey events > temporarily and they don't get _stored_ like in the System Event FIFO.
Yes, you shouldn't be reading directly from TOHK at any point. It seems to be a purely internal variable - I'm fairly sure that the INFO method is the only one that should be called on event generation.
> On the patches I sent to the omnibook module I'm able to get events but they > seem to get repeated 3 times, or perhaps I'm polling to often.
Hm. I don't have test hardware right now, I'm afraid. I'll look at some DSDTs a bit more and see if anything springs to mind.
-- Matthew Garrett | mjg59@srcf.ucam.org
| |