lkml.org 
[lkml]   [2009]   [Apr]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 15/17] bio/blk-map: kill unused stuff and un-export internal functions
On 04/01/2009 04:44 PM, Tejun Heo wrote:
> Impact: cleanup, removal of unused / undesirable API
>
> With recent changes, the following functions aren't used anymore.
>
> * bio_{map|copy}_{user|kern}()
> * blk_rq_append_bio()
>

This function is used by drivers/scsi/osd/osd_initiator.c
Currently in mainline. Please use allmodconfig to compile
everything.

> The following functions aren't used outside of block layer.
>
> * bio_add_pc_page()

And also this

> * bio_un{map|copy}_user()
>
> Kill the first group and unexport the second. As bio_add_pc_page() is
> used only inside fs/bio.c, it's made static.
>
> Signed-off-by: Tejun Heo <tj@kernel.org>

I've posted propositions on how to fix osd_initiator.c which
involves making blk_map_kern() append to the request, and a new
blk_make_request(bio).

Any suggestions are welcome

Thanks
Boaz


\
 
 \ /
  Last update: 2009-04-01 16:01    [W:0.367 / U:0.060 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site