Messages in this thread | | | Subject | Re: [patch/rfc 2.6.29 2/2] MTD: support driver model updates | From | Artem Bityutskiy <> | Date | Wed, 01 Apr 2009 09:10:03 +0300 |
| |
On Tue, 2009-03-31 at 22:57 -0700, David Brownell wrote: > On Tuesday 31 March 2009, Artem Bityutskiy wrote: > > > --- a/drivers/mtd/nand/mxc_nand.c > > > +++ b/drivers/mtd/nand/mxc_nand.c > > > @@ -866,6 +866,7 @@ static int __init mxcnd_probe(struct pla > > > mtd = &host->mtd; > > > mtd->priv = this; > > > mtd->owner = THIS_MODULE; > > > + mtd->dev.parent = &pdev->dev; > > > > Could this be done for all NANDs in nand_base.c instead? > > By adding the device as a parameter to nand_scan(), > and presumably nand_scan_ident() ... which is a more > invasive API change, and would require a "flag day" > to convert all drivers. > > My default assumption for API changes is to avoid > flag days. They can be done, yes, but I don't see > a compelling reason to choose one here.
OK. MTD long needs sysfs, and I'm very happy with this patches, even though they are not 100% complete. Good start anyway.
Acked-by: Artem Bityutskiy <dedekind@infradead.org>
-- Best regards, Artem Bityutskiy (Битюцкий Артём)
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |