Messages in this thread | | | Date | Tue, 31 Mar 2009 22:56:28 -0700 | Subject | Re: Inverted NUMA test in setup_pcpu_remap()? | From | Yinghai Lu <> |
| |
On Tue, Mar 31, 2009 at 10:31 PM, David Miller <davem@davemloft.net> wrote: > > The test currently is: > > if (!cpu_has_pse || pcpu_need_numa()) > return -EINVAL; > > Don't we really mean "!pcpu_need_numa()"? > > The way I read the intent, setup_pcpu_remap() should be used in the > NUMA case. But that's not what's happening because of how this test > is coded. > > In fact, the test here is identical to the one used in > setup_pcpu_embed() > --
you are right. on one 4 sockets system got
[ 0.000000] PERCPU: Allocated 471 4k pages, static data 1925472 bytes
that is from setup_pcpu_4k...
YH -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |