lkml.org 
[lkml]   [2009]   [Mar]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] ftrace: fix crash due to tracing of __naked functions
El Mon, Mar 09, 2009 at 08:46:40AM +0100 Uwe Kleine-König ha dit:

> This is a fix for the following crash observed in 2.6.29-rc3:
> http://lkml.org/lkml/2009/1/29/150
>
> On ARM it doesn't make sense to trace a naked function because then
> mcount is called without stack and frame pointer being set up and there
> is no chance to restore the lr register to the value before mcount was
> called.
>
> Compared to the original fix posted to arm-linux-kernel ML on 29 Jan
> 2009 by Abhishek Sagar I only changed the definition of __naked for ARM.
>
> Reported-by: Matthias Kaehlcke <matthias@kaehlcke.net>
> Cc: Abhishek Sagar <sagar.abhishek@gmail.com>
> Cc: Russell King <linux@arm.linux.org.uk>
> Cc: Steven Rostedt <rostedt@home.goodmis.org>
> Cc: Ingo Molnar <mingo@elte.hu>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> Hello,
>
> without this change a kernel having CONFIG_FUNCTION_TRACER=y doesn't
> boot on many maschines. It would be great if this change would make it
> into .29.

i agree that it would be convenient to have this resolved in .29

Tested-by: Matthias Kaehlcke <matthias@kaehlcke.net>

--
Matthias Kaehlcke
Embedded Linux Engineer
Barcelona


The salvation of mankind lies only in making everything the concern of all
(Alexander Solzhenitsyn)
.''`.
using free software / Debian GNU/Linux | http://debian.org : :' :
`. `'`
gpg --keyserver pgp.mit.edu --recv-keys 47D8E5D4 `-
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2009-03-09 11:37    [W:0.054 / U:2.020 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site