lkml.org 
[lkml]   [2009]   [Mar]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] block: fix memory leak in bio_clone()
On Mon, Mar 09 2009, Li Zefan wrote:
> >>> as the mempool mask. So the leak will not occur, but it does mean that
> >>> it isn't honoring the gfp_mask passed in to bio_clone(), which is the
> >> I noticed there was a patch to do this, and seems you planed to merge
> >> it into .29?
> >>
> >> "[PATCH] Add gfp_mask to bio_integrity_clone()"
> >>
> >> http://lkml.org/lkml/2008/10/30/11
> >
> > Hmm strange, apparently that never got queued up and I had forgotten all
> > about that issue until your email. I'll add it asap.
> >
>
> I found bio_integrity_clone() is not using the gfp_mask passed by bio_clone(),
> so I googled it in LKML before I fix it. :)

I've got both patches queued up now:

http://git.kernel.dk/?p=linux-2.6-block.git;a=shortlog;h=refs/heads/for-linus

> >>> first bug. The second bug is that it should be using its own bioset, as
> >>> it is illegal to do multiple __GFP_WAIT allocations on a single mempool
> >>> and always expect progress.
> >
> > That one still stands.
> >
>
> Yes, and I'd leave it to you or Martin. ;)

I'll let Martin sort that out, it can easily wait for the next release.

--
Jens Axboe



\
 
 \ /
  Last update: 2009-03-09 10:57    [W:0.037 / U:15.328 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site