lkml.org 
[lkml]   [2009]   [Mar]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v10 4/7] PCI: add SR-IOV API for Physical Function driver
    On Mon, Mar 09, 2009 at 04:25:05PM +0800, Yu Zhao wrote:
    > > > + pci_device_add(virtfn, virtfn->bus);
    > >
    > > Greg is probably going to ding you here for adding the device, then
    > > creating the symlinks. I believe it's now best practice to create the
    > > symlinks first, so there's no window where userspace can get confused.
    >
    > Yes, but unfortunately we can't create links before adding a device.
    > I double checked device_add(), there is no place for those links to be
    > created before it sends uevent. So for now, we have to trigger another
    > uevent for those links.

    What exactly are you trying to do with a symlink here that you need to
    do it this way? I vaguely remember you mentioning this in the past, but
    I thought you had dropped the symlinks after our conversation about this
    very problem.

    thanks,

    greg k-h


    \
     
     \ /
      Last update: 2009-03-09 20:49    [W:4.169 / U:0.120 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site