lkml.org 
[lkml]   [2009]   [Mar]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] copy_process: fix CLONE_PARENT && parent_exec_id interaction
On 03/09, David Howells wrote:
>
> Oleg Nesterov <oleg@redhat.com> wrote:
>
> > - /* Our parent execution domain becomes current domain
> > - These must match for thread signalling to apply */
>
> Should you retain this comment somewhere?

This comment should be changed, but I failed to make the new one.
Actually, this was one of the reasons why the first patch I sent
http://marc.info/?l=linux-kernel&m=123602926516698
didn't touch the first ""p->parent_exec_id = ...".

There is a fat comment in exit_notify(), perhaps we can just add
/* see the comment in exit_notify() */.

But the "good" commenent should also explain that, since we re-use
->real_parent, the child also "inherits" the rights _and_ restrictions
to send ->exit_signal != SIGCHLD.

Oleg.



\
 
 \ /
  Last update: 2009-03-09 19:39    [W:0.027 / U:6.604 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site