lkml.org 
[lkml]   [2009]   [Mar]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 08/10] ide: move ide_map_sg() call out from ->dma_setup method
Bartlomiej Zolnierkiewicz wrote:

> Move ide_map_sg() call from ->dma_setup implementations
> and ide_destroy_dmatable() one from *_build_dmatable() to
> ide_dma_prepare().
>
> There should be no functional changes caused by this patch.
>
> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
>
[...]
> Index: b/drivers/ide/au1xxx-ide.c
> ===================================================================
> --- a/drivers/ide/au1xxx-ide.c
> +++ b/drivers/ide/au1xxx-ide.c
> @@ -272,9 +272,7 @@ static int auide_build_dmatable(ide_driv
> if (count)
> return 1;
>
> - use_pio_instead:
> - ide_destroy_dmatable(drive);
> -
> +use_pio_instead:
>

Could you please get rid of goto and label too, while at it?

> Index: b/drivers/ide/pmac.c
> ===================================================================
> --- a/drivers/ide/pmac.c
> +++ b/drivers/ide/pmac.c
> @@ -1493,8 +1493,6 @@ static int pmac_ide_build_dmatable(ide_d
> printk(KERN_DEBUG "%s: empty DMA table?\n", drive->name);
>
> use_pio_instead:
> - ide_destroy_dmatable(drive);
> -
> return 0; /* revert to PIO for this request */

Ditto...

> Index: b/drivers/ide/sgiioc4.c
> ===================================================================
> --- a/drivers/ide/sgiioc4.c
> +++ b/drivers/ide/sgiioc4.c
> @@ -478,8 +478,6 @@ static int sgiioc4_build_dmatable(ide_dr
> }
>
> use_pio_instead:
> - ide_destroy_dmatable(drive);
> -
> return 0; /* revert to PIO for this request */
>

Ditto...

MBR, Sergei




\
 
 \ /
  Last update: 2009-03-09 15:45    [W:0.210 / U:0.436 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site