Messages in this thread | | | Date | Mon, 9 Mar 2009 15:12:16 +0100 | From | Alessandro Zummo <> | Subject | Re: [rtc-linux] [PATCH 7/7] powerpc/ps3: Add rtc-ps3 |
| |
On Mon, 9 Mar 2009 14:26:23 +0100 Geert Uytterhoeven <Geert.Uytterhoeven@sonycom.com> wrote:
Hi,
just a few notes:
> + > +static int ps3_get_time(struct device *dev, struct rtc_time *tm) > +{ > + to_tm(read_rtc() + ps3_os_area_get_rtc_diff(), tm); > + tm->tm_year -= 1900; > + tm->tm_mon -= 1; > + return 0; > +}
this should be return rtc_valid_tm() .
can't you use functions from rtc-lib.c instead of that to_tm ?
> + > +MODULE_AUTHOR("Sony Corporation");
real name, if possible and a contact address here . Just in case I need someone to bother :)
--
Best regards,
Alessandro Zummo, Tower Technologies - Torino, Italy
http://www.towertech.it
| |