lkml.org 
[lkml]   [2009]   [Mar]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH] toshiba_acpi: Add full hotkey support
    Date
    On 8 марта 2009 11:33:48 Richard Hughes wrote:
    > On Sat, Mar 7, 2009 at 8:26 PM, Matthew Garrett <mjg59@srcf.ucam.org>
    wrote:
    > > On Sat, Mar 07, 2009 at 08:19:51PM +0000, Richard Hughes wrote:
    > >> Mapping KEY_SUSPEND to hibernate is just insane. Can you please
    > >> change the toshiba driver to use KEY_HIBERNATE and KEY_SUSPEND as
    > >> thinkpad now does? Thanks.
    > >
    > > Mapping KEY_SUSPEND to hibernate is what we've been doing for
    > > years. It's what hal *still does*.
    >
    > Sure, but how much userspace now listens to HAL for these events?

    Apparently KDE still does. At least it does not seem to pay any
    attention to KEY_SUSPEND (nor KEY_SLEEP BTW).

    And KDE seems to be important enough customer to not wish to break HAL.

    > Xorg and evdev has taken over that role for all the session.

    Oh, wait. But even Xorg 1.6.0 interprets KEY_SUSPEND as "hibernate".

    KeyPress event, serial 31, synthetic NO, window 0x3e00001,
    root 0xbc, subw 0x0, time 87299792, (81,-11), root:(817,290),
    state 0x0, keycode 213 (keysym 0x1008ffa8, XF86Hibernate),
    same_screen YES,
    XLookupString gives 0 bytes:
    XmbLookupString gives 0 bytes:
    XFilterEvent returns: False

    So redefining KEY_SUSPEND is going to break Xorg too (as long as anyone
    is using those keysyms).

    > We can
    > ship a trivial patch as an fdi file to HAL to remap this if required.
    >
    > > KEY_SLEEP has been the suspend to RAM key forever.

    Ehh ... actually at least in Toshiba case it was not :) hald Toshiba
    add-on always emitted exactly "suspend" and "hibernate" D-Bus events.
    Not "sleep".


    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2009-03-08 15:33    [W:2.105 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site