[lkml]   [2009]   [Mar]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Subject[PATCH 0/5][v2] Simplify devpts code

This patchset tries to address Christoph Hellwig's review comments on the
support for multiple-instances in devpts.
It breaks up the patch into smaller pieces for (hopefully) easier review.

IIUC, the key observation was that most of do_remount_sb() (MS_RDONLY flag
and shrink_dcache() does not apply to devpts and only the parsing of
options does. Moving the parsing code into devpts enables us to parse
the options just once and vastly simplifies the code.

This patchset does not change any functionality/behavior. But it does
depend on following two related patches.

Patches in this set:

[PATCH 1/5] Unroll essentials of do_remount_sb() into devpts
[PATCH 2/5] Parse mount options just once and copy them to super block
[PATCH 3/5] Move common mknod_ptmx() calls into caller
[PATCH 4/5] Remove get_init_pts_sb()
[PATCH 5/5] Merge code for single and multiple-instance mounts

- (Serge Hallyn): Remove unnecessary printks

- (Christoph Hellwig) Patch 2/5 remove '//check' comment. Initialized
object using memset().
- (Christoph Hellwig) - Patch 5/5; Removed the do_pts_mount() function
and moved that code into devpts_get_sb()

TODO: (Independent patch set)

- Merge CONFIG_DEVPTS_MULTIPLE_INSTANCES token with other container-
related tokens ?

 \ /
  Last update: 2009-03-07 19:13    [W:0.107 / U:45.732 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site