Messages in this thread | | | Date | Fri, 6 Mar 2009 13:24:38 -0800 | From | Andrew Morton <> | Subject | Re: [PATCH] mtd: plat_nand: add platform probe/remove callbacks |
| |
On Thu, 5 Mar 2009 18:58:12 -0500 "hartleys" <hartleys@visionengravers.com> wrote:
> From: "hartleys" <hartleys@visionengravers.com>
You might want to change your email setup so that the above reads "H Hartley Sweeten <hsweeten@visionengravers.com>" or whatever. Because most patch-merging people's tools will end up marking this commit as being from someone called "hartleys".
Alternatively, put an explicit From: line at the top of the changelog.
> To: <linux-kernel@vger.kernel.org> > Cc: <linux-mtd@lists.infradead.org>, "Alexander Clouter" <alex@digriz.org.uk>, "Andrew Morton" <akpm@linux-foundation.org>, <vitalywool@gmail.com> > Subject: [PATCH] mtd: plat_nand: add platform probe/remove callbacks > Date: Thu, 5 Mar 2009 18:58:12 -0500 > > Add optional probe and remove callbacks to the plat_nand driver. > > Some platforms may require additional setup, such as configuring > the memory controller, before the nand device can be accessed. > This patch provides an optional callback to handle this setup as > well as a callback to teardown the setup. > > This patch was originally submitted to linux-mtd but it was > suggested I post it here for a broader review.
Looks OK to me, but I'm an MTD ignoramus.
> Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com> > Tested-By: Alexander Clouter <alex@digriz.org.uk> > > --- > > diff --git a/drivers/mtd/nand/plat_nand.c b/drivers/mtd/nand/plat_nand.c > index 75f9f48..600fbe9 100644
The patch was quite wordwrapped. Please fix your email client for next time.
| |