lkml.org 
[lkml]   [2009]   [Mar]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [v2 PATCH 4/4] timers: logic to enable timer migration.
    On Thu, Mar 05, 2009 at 05:23:29PM +0100, Oleg Nesterov wrote:
    > On 03/04, Arun R Bharadwaj wrote:
    > >
    > > +++ linux.trees.git/kernel/sched.c
    > > @@ -4009,6 +4009,11 @@ static struct {
    > > .load_balancer = ATOMIC_INIT(-1),
    > > };
    > >
    > > +inline int get_nohz_load_balancer(void)
    >
    > inline?
    >
    > > +{
    > > + return atomic_read(&nohz.load_balancer);
    > > +}
    >
    > Shouldn't we reset .load_balancer when this CPU is CPU_DOWN'ed ?
    > Otherwise the timer can migrate to the dead CPU.

    In the select_nohz_load_balancer() code, we check if this CPU is in the
    cpu_active_map. If no, then this CPU relinquishes being the idle
    load balancer. Also, the timer migration code in the CPU down path would
    migrate any timers queued onto this CPU, right ?

    >
    > Oleg.

    --
    Thanks and Regards
    gautham


    \
     
     \ /
      Last update: 2009-03-06 04:25    [W:3.497 / U:0.128 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site