[lkml]   [2009]   [Mar]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH 3/3] ide-{cd,floppy}: do not map all cmds to an sg
    On Thursday 05 March 2009, Borislav Petkov wrote:
    > Hi,
    > > Unrelated to the original issue that the patch tries to fix
    > > (sg mapping no data commands which OOPS-es w/ DEBUG_VIRTUAL=y):
    > > - moving ide_init_sg_cmd()+ide_map_sg() to ide_issue_pc()
    > > - converting the code to use blk_rq_bytes()
    > aah, ok, now I could get exactly what you meant :). However, (!) ide-floppy is
    > potentially broken in the same way for data-less cmds since we unconditionally

    Indeed, you are right but it seems that this is not a new problem.

    Wait... it makes things "worse" as there should have been 3 patches:
    (IOW _three_ patchpoints! ;):

    - ide-cd fix for problematic patch
    - ide-floppy fix for mainline
    - ide-atapi cleanup for pata tree


     \ /
      Last update: 2009-03-05 17:53    [W:0.019 / U:24.544 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site