lkml.org 
[lkml]   [2009]   [Mar]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [v2 PATCH 4/4] timers: logic to enable timer migration.
    On 03/04, Arun R Bharadwaj wrote:
    >
    > +++ linux.trees.git/kernel/sched.c
    > @@ -4009,6 +4009,11 @@ static struct {
    > .load_balancer = ATOMIC_INIT(-1),
    > };
    >
    > +inline int get_nohz_load_balancer(void)

    inline?

    > +{
    > + return atomic_read(&nohz.load_balancer);
    > +}

    Shouldn't we reset .load_balancer when this CPU is CPU_DOWN'ed ?
    Otherwise the timer can migrate to the dead CPU.

    Oleg.



    \
     
     \ /
      Last update: 2009-03-05 17:29    [W:4.304 / U:0.120 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site