Messages in this thread | | | Date | Wed, 04 Mar 2009 10:26:07 +0100 | From | Hans-Christian Egtvedt <> | Subject | Re: [PATCH 0/5] WM97xx updates |
| |
Dmitry Torokhov wrote: > On Tue, Mar 03, 2009 at 06:24:03PM +0000, Mark Brown wrote: >> This patch series updates the review feedback from the first round and >> rolls in the additional patches from Mike Rapoport. I've not addressed >> any of the comments for the at32 driver since I have no ability to test >> any changes to that driver but repost it for completeness. >> > > I applied first 4 patches to 'next' and will wait for Hans-Christian > comments on the at32 driver. >
The only thing catched by review was a leaking irq line, do you plan to fixup that Mark?
I also think the header file could go into the source code, to make it one file less.
Also, please note that I've gotten a new email address. The old one is quite annoying since it sends email back about my new address...
I'll not be able to test the driver immediately, my hardware is out at customers and the eight new prototypes needs some resoldering before I can work with them. Nothing has changed in hardware though, so it should fly out of the box.
-- Best regards, Hans-Christian Egtvedt
| |